[DPE-7603][DPE-6990] Fix check in relation initialisation #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
marceloneppel
added
the
not bug or enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
=======================================
Coverage 73.29% 73.29%
=======================================
Files 15 15
Lines 3921 3921
Branches 574 574
=======================================
Hits 2874 2874
Misses 833 833
Partials 214 214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
dragomirp
approved these changes
Aug 12, 2025
|
We'll most probably need to remove the old cla-check to be able to merge. |
taurus-forever
approved these changes
Aug 13, 2025
marceloneppel
changed the title
…-initialisation Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The handler for the
database_requestedevent creates a new user through the primary, but checks if the current unit is has started PostgreSQL. The current unit may be the leader but not the primary, which may lead to errors when trying to access the database.There is also the case where, for some reason, the K8s PG primary service stops redirecting traffic to the unit for a short period. This makes the charm understand that the cluster has initialised completely and can create users (but it may not due to that weird situation). This still needs further investigation.
Solution
Use the right condition (primary endpoint being ready) in the check.
Fixes #1011
Fixes #927
Checklist